Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved search URLs are broken since upgrade from 0.28.4 to 0.29 #1115

Closed
gburjan opened this issue Dec 13, 2016 · 1 comment · Fixed by #1132
Closed

Saved search URLs are broken since upgrade from 0.28.4 to 0.29 #1115

gburjan opened this issue Dec 13, 2016 · 1 comment · Fixed by #1132
Assignees
Labels

Comments

@gburjan
Copy link

gburjan commented Dec 13, 2016

In the former version (nipap-www 0.28.4) when we did a search on the web UI and saved its link, it worked again after opening it in another browser window. This behaviour changed after the upgrade. I think that this can be caused by the modification introduced in this changeset:

https://github.com/SpriteLink/NIPAP/blob/57834938ba84587ceaa07ac4ec901139890add70/nipap-www/nipapwww/public/nipap.js

Regarding to the git log message, the only change is that an extra slash is inserted before query_string, but if we modify the formerly saved

https://ipam.company.com/prefix/list#query_string=stringToSearch&search_opt_parent=undefined&search_opt_child=undefined&explicit=true

style URLs to

https://ipam.company.com/prefix/list#/query_string=stringToSearch&search_opt_parent=undefined&search_opt_child=undefined&explicit=true

it simply omits the specified "stringToSearch" argument and lists all prefixes.

@garberg
Copy link
Member

garberg commented Feb 16, 2017

Probably related to #1089.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants