Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Finish all completions of NbtArgumentParser. #38

Merged
merged 11 commits into from
Oct 28, 2019
Merged

✨ Finish all completions of NbtArgumentParser. #38

merged 11 commits into from
Oct 28, 2019

Conversation

SPGoding
Copy link
Member

@SPGoding SPGoding commented Oct 27, 2019 •
edited
Loading

Resolve #28.

@SPGoding SPGoding added the ✨ feature New feature or request label Oct 27, 2019
@SPGoding SPGoding self-assigned this Oct 27, 2019
@SPGoding SPGoding added this to In progress in Gilded Age via automation Oct 27, 2019
@codecov
Copy link

codecov bot commented Oct 27, 2019 •
edited
Loading

Codecov Report

Merging #38 into issues/#4 will increase coverage by 0.47%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##           issues/#4      #38      +/-   ##
=============================================
+ Coverage      95.17%   95.64%   +0.47%     
=============================================
  Files             29       29              
  Lines           1056     1171     +115     
  Branches         245      277      +32     
=============================================
+ Hits            1005     1120     +115     
  Misses            51       51
Impacted Files Coverage Δ
src/parsers/StringArgumentParser.ts 100% <ø> (ø) ⬆️
src/parsers/ArgumentParser.ts 100% <ø> (ø) ⬆️
src/types/Parser.ts 100% <100%> (ø) ⬆️
src/parsers/LineParser.ts 100% <100%> (ø) ⬆️
src/parsers/DefinitionDescriptionArgumentParser.ts 100% <100%> (ø) ⬆️
src/types/ParsingError.ts 100% <100%> (ø) ⬆️
src/parsers/LiteralArgumentParser.ts 100% <100%> (ø) ⬆️
src/parsers/NbtTagArgumentParser.ts 100% <100%> (ø) ⬆️
src/parsers/ArgumentParsers.ts 100% <100%> (ø)
src/parsers/EntityArgumentParser.ts 60% <100%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9dda2d...15d6119. Read the comment docs.

@SPGoding SPGoding marked this pull request as ready for review October 28, 2019 11:01
@SPGoding SPGoding merged commit 15d6119 into issues/#4 Oct 28, 2019
Gilded Age automation moved this from In progress to Done Oct 28, 2019
@SPGoding SPGoding deleted the issues/#28 branch October 28, 2019 11:03
@SPGoding
Copy link
Member Author

SPGoding commented Nov 4, 2019

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SPGoding SPGoding added 👌 resolved *released The changes has been released labels Nov 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@SPGoding SPGoding

Labels
✨ feature New feature or request *released The changes has been released
Projects
No open projects
Gilded Age
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SPGoding @renovate-bot