Disable registration when authorization.strategy is password #19
Conversation
|
I'd be opening to accepting it upstream if it's tested and documented. A search for if Squash::Configuration.authentication.strategy == 'password'is a good place to start to see my strategy in implementing a lot of this conditional auth strategy code. |
|
Great. I'll take a look into it and provide a PR so we can discuss this further. |
|
@nicolai86 have you started implemented anything? This is crucial for me now ;) So if you haven't started anything, I would love to prepare possibility to turn off registration (via config file for start). |
|
@mlitwiniuk if already got a running working solution (without tests, tho) but I have not yet had time to make a PR out of it. |
|
give me a second and I'll provide a PR... |
- add Squash::Configuration.authentication.registration_enabled
|
@mlitwiniuk there you go, working pull request extracted out of my currently deployed squash instance. Tests will be coming soon, too. |
|
there you go, simple test. feedback? |
|
that was fast, seems to do the trick. Thanks, I'll try that tomorrow. |
|
This looks good initially; I'll be taking a more thorough look this week hopefully. |
|
Committed and pushed with some code tweaks. 05e3836 |
Hey there,
when running squash web I'd like to disable registration since everybody who registers can join an existing project.
This functionality could be integrated fairly easy by adding a new setting to the authorization.yml and some changes to the routes and the sessions/new view, but I wanted to ask first if this feature whould be acccepted upstream.
I'd like to know if you would consider the authorization.yml the correct place to add such a feature. I'd argue that introducing a second authorization level (eg admin, user) and adding a settings page for admins where such things can be changed without having to restart the app would be a good addition.
Any suggestions/ feedback?
I'd be more than happy to provide a pull request later on!
Cheers, Raphael