New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
squirrel packages entire electron.exe in every update (electron-winstaller) (fix already in master) #1784
Comments
@anaisbetts (sorry for the ping, I believe you're still the de facto maintainer/permission-holder) if I make a PR cherry-picking this fix into the development branch and then talk to the electron-winstaller maintainers about releasing a new version picking up the change, will the PR get accepted? |
@robmen is this something that you can accept via PR? |
@MichaelBelousov so I'm clear, is this simply a commit (or two) in |
yes exactly. The description above references the exact commit. I've been using a fork with the one commit cherry-picked. |
Okay, I have the changes in However, your real question is what is the process for |
@robmen would it be appropriate for me to open a new tracking issue for updating the electron-winstaller package with the latest squirrel? |
Squirrel version(s)
2.01-eef3746
Description
electron-winstaller's vendored squirrel's bsdiff fails to diff electron.exe's which differ only by 4 bytes, the 4 references to updated versions embedded in the exe. This causes squirrel to package the entire electron.exe every update.
As discussed in #1287, this is already fixed in master. But for some reason it was never cherry-picked to the development branch from which the electron-winstaller vendored binaries are from
The PR to master where a fix was added #1421
Steps to recreate
See #1287
this invokes their vendored 2.01 squirrel
Expected behavior
A small-ish patch for the app's renamed electron.exe executable is generated rather than the entire file placed in the update.
Actual behavior
squirrel's bsdiff fails because there is only is no bsdiff-extra-data generated by diffing this case, and there is a divide by zero error when trying to write an empty byte stream for the diff. The error is taken as reason to just stuff the binary file in the update if diffing failed.
The text was updated successfully, but these errors were encountered: