fix bsdiff creation for patches that don't contain bsdiff extra data #1421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a created bsdiff patch does not contain any extra data, a
System.DivideByZeroException
is thrown by SharpCompress when trying to compress the (zero-sized) extra data (as also reported in #1101 ).This fix skips writing and reading the extra data if there is none in the patch.
For us, this was also the cause of electron/windows-installer#185.