Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HER + update to gym 0.26+ #9

Merged
merged 11 commits into from
Apr 14, 2023

Conversation

arjun-kg
Copy link
Contributor

@arjun-kg arjun-kg commented May 9, 2022

To be merged after next SB3 release. Notebooks run with SB3 at this fork (DLR-RM/stable-baselines3#780)

  1. Updated to new seed method in one file
  2. Updated HER to be compatible with latest SB3

Copy link
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again =)

@araffin araffin changed the title Update HER + update to gym 0.23.1 Update HER + update to gym 0.26+ Oct 13, 2022
@tlpss
Copy link
Contributor

tlpss commented Oct 13, 2022

The wandb integration is not working for gym v0.26 yet, see wandb/wandb#4305. A PR seems to be in place so I'm hoping this gets merged and released soon.

@tlpss
Copy link
Contributor

tlpss commented Oct 13, 2022

@araffin 3 notebooks are not working yet for gym v0.26:

@araffin
Copy link
Member

araffin commented Oct 17, 2022

pybullet_envs -> no word on gym v0.26 yet, repo seems to have low activity (pybullet is no longer actively developed after all)

Pull request is here: bulletphysics/bullet3#4335

Pybullet is no longer actively maintained but that doesn't mean it's not usable/useful (especially pybullet envs are more interestings and challenging than the mujoco equivalents).

@tlpss
Copy link
Contributor

tlpss commented Oct 18, 2022

Pull request is here: bulletphysics/bullet3#4335

Ah my bad, I was looking in the pybullet-gym repo.

Pybullet is no longer actively maintained but that doesn't mean it's not usable/useful

Couldn't agree more! I have been using it extensively the past months.

@araffin
Copy link
Member

araffin commented Oct 31, 2022

pybullet_envs -> no word on gymv0.26 yet Bullet3 in progress

we could activate the compatibility in the meantime, no?

Nevermind, gym breaks pybullet by breaking changes in its registry...

@vwxyzjn vwxyzjn mentioned this pull request Dec 28, 2022
19 tasks
@araffin
Copy link
Member

araffin commented Jan 5, 2023

pybullet_envs -> no word on gymv0.26 yet Bullet3 in progress (compatibility with Gym 0.26.0 bulletphysics/bullet3#4335)

We should probably patch it the way I did for the RL Zoo: bulletphysics/bullet3#4368 (comment)

EDIT: done

@araffin araffin merged commit 92a5d85 into Stable-Baselines-Team:sb3 Apr 14, 2023
@araffin araffin deleted the gym0.23.1 branch April 14, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants