Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gym 0.26 support #256

Closed
wants to merge 46 commits into from
Closed

Add Gym 0.26 support #256

wants to merge 46 commits into from

Conversation

araffin
Copy link
Member

@araffin araffin commented May 29, 2022

Description

See DLR-RM/stable-baselines3#780 for installation or usage with Gymnasium

List of things (probably incomplete) that need to be done. Add if you see others.

Note: I had to patch gym for pybullet and the TimeLimit wrapper

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

@qgallouedec qgallouedec mentioned this pull request Jun 3, 2022
13 tasks
@qgallouedec
Copy link
Collaborator

qgallouedec commented Oct 26, 2022

List of things (probably incomplete) that need to be done. Add if you see others.

  • Update step methods - The Env.step function returns 5 values instead of 4 previously (observations, reward, termination, truncation, info).
  • Update reset - The Env.reset function returns two values (obs and info)
  • Update seed - Env.seed no longer exists, instead, use gym.reset(seed=...)
  • Update rendering - render arguments can be part of the environment's constructor i.e., gym.make("CartPole-v1", render_mode="human")

EDIT: Outdated, fill the checklist in the description instead

@araffin araffin changed the title Add gym 0.24 support Add gym 0.26 support Oct 26, 2022
@araffin
Copy link
Member Author

araffin commented Oct 26, 2022

I added the TODOs to the description ;)

@araffin
Copy link
Member Author

araffin commented Oct 26, 2022

@qgallouedec the API change is only for the wrapper, for the rest, VecEnv should work as before (except the render mode I think, that was already a bit hacky anyway with pybullet)

@qgallouedec
Copy link
Collaborator

qgallouedec commented Dec 19, 2022

a7bdc5e: panda-gym fixed in v3.0.1

@araffin araffin changed the title Add gym 0.26 support Add Gym(nasium) 0.26 support Dec 23, 2022
@araffin araffin mentioned this pull request Feb 13, 2023
13 tasks
@araffin araffin changed the title Add Gym(nasium) 0.26 support Add Gym 0.26 support Mar 11, 2023
@araffin araffin closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants