fix: open link on Mod-Click #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mages from an external url fixes: #43
…eanup the next commit's diff
dancormier
added
bug
✅ Deploy Preview for nifty-lalande-39c157 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
b-kelly
requested changes
Jun 2, 2022
| * Returns the mark at cursor if it is of type `link` | ||
| * @param state The current editor state | ||
| */ | ||
| function findLinkAtCursor(state: EditorState): Mark { |
There was a problem hiding this comment.
I think we can chuck this functionality into the link-tooltip plugin and avoid having to add another plugin. I'd wait on this for the time being though, as I'm nearly finished with a total overhaul of that file and changing it would cause some nasty merge conflicts.
b-kelly
force-pushed
the
main
branch
6 times, most recently
from
1e96950
to
3e4c847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #62
TODO