-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: open link on Mod-Click #130
Conversation
…mages from an external url fixes: #43
…eanup the next commit's diff
✅ Deploy Preview for nifty-lalande-39c157 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking merge, waiting for tests and changes to link-editor plugin
* Returns the mark at cursor if it is of type `link` | ||
* @param state The current editor state | ||
*/ | ||
function findLinkAtCursor(state: EditorState): Mark { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can chuck this functionality into the link-tooltip
plugin and avoid having to add another plugin. I'd wait on this for the time being though, as I'm nearly finished with a total overhaul of that file and changing it would cause some nasty merge conflicts.
1e96950
to
3e4c847
Compare
fixes #62
TODO