Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to disallow embedding uploaded images #61

Closed
b-kelly opened this issue Mar 17, 2021 · 1 comment
Closed

Add setting to disallow embedding uploaded images #61

b-kelly opened this issue Mar 17, 2021 · 1 comment
Labels
commonmark Relates to commonmark round-tripping or syntax enhancement New feature or request
Milestone

Comments

@b-kelly
Copy link
Collaborator

b-kelly commented Mar 17, 2021

Is your feature request related to a problem? Please describe.

Currently, when an image is uploaded, it is always embedded as an image. There needs to be a setting to force uploaded images to be embedded as links instead.

Additional context

The Stack Exchange network requires this feature, as users with too low of a reputation are disallowed from embedding images.

@b-kelly b-kelly added the enhancement New feature or request label Mar 17, 2021
@b-kelly b-kelly added the commonmark Relates to commonmark round-tripping or syntax label Oct 7, 2021
@b-kelly b-kelly added this to the Beta 1 milestone Apr 20, 2022
@b-kelly
Copy link
Collaborator Author

b-kelly commented May 16, 2022

Current behavior on Stack Overflow:

  1. User uploads an image
  2. Image gets uploaded, then embedded as a link and the user is notified via a popup
  3. User creates an image manually via markdown - submit fails due to server-side error

In our case, we're going to only support the "image is embedded as a link" and leave the popover / validation to the implementer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commonmark Relates to commonmark round-tripping or syntax enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant