Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown bullet list command strips numbers from the start of lines #69

Closed
b-kelly opened this issue Apr 21, 2021 · 0 comments · Fixed by #140
Closed

Markdown bullet list command strips numbers from the start of lines #69

b-kelly opened this issue Apr 21, 2021 · 0 comments · Fixed by #140
Labels
bug Something isn't working good first issue Good for newcomers mode - markdown Affects the editor's markdown input mode
Milestone

Comments

@b-kelly
Copy link
Collaborator

b-kelly commented Apr 21, 2021

Reported on Meta.SE here.

Describe the bug

Using the unordered list command in markdown mode trims numbers from the start of the string.

To Reproduce

Add text to markdown mode like the following:

3 users need to foo the bar
then the bar becomes foo
4 bars have been foo'd

Highlight all 3 lines, then click the "bulleted list" command button.

The resulting text looks like:

- users need to foo the bar
- then the bar becomes foo
- bars have been foo'd

but should look like:

- 3 users need to foo the bar
- then the bar becomes foo
- 4 bars have been foo'd
@b-kelly b-kelly added bug Something isn't working good first issue Good for newcomers labels Apr 21, 2021
@b-kelly b-kelly added the mode - markdown Affects the editor's markdown input mode label Oct 7, 2021
@b-kelly b-kelly added this to the Beta 2 milestone Apr 20, 2022
dancormier added a commit that referenced this issue Jun 16, 2022
* fix: prevent block change from stripping numbers

fixes #69

* add matchLeadingBlockCharacters tests

* docs(commands): reseat TODOs for match regex

* fix(commands): add support for all ordered list markers in matchLeadingBlockCharacters

Co-authored-by: Ben Kelly <b-kelly@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers mode - markdown Affects the editor's markdown input mode
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant