Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROUTE53: Docs should specify FQDN with dot. #1130

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Conversation

tlimoncelli
Copy link
Contributor

After helping with #1128 I noticed that the examples don't include a "." at the end of FQDNs. I think that lead to the confusion.

Here's a PR with corrected (I hope) examples. Are they more correct?

CC @masterzen

After helping with
#1128 I noticed that
the examples don't include a "." at the end of FQDNs.

Are these examples more correct?
Copy link
Contributor

@masterzen masterzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the trailing . seems mandatory.
But I couldn't find anywhere in the AWS Route53 documentation a mention for ALIAS records. The mention that the trailing dot is optional for records that take a domain as target, like CNAME (see https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/ResourceRecordTypes.html).
ALIAS are essentially A records, so I assume that this doesn't match the aforementioned rule :)

So I looked to the R53_ALIAS I have in my dnscontrol setup and indeed, all have a trailing dot. So my bad for this non working sample.

Approving :)

@tlimoncelli tlimoncelli merged commit 554c9ae into master Apr 22, 2021
@tlimoncelli tlimoncelli deleted the tlim_r53alias branch April 22, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants