providers/route53/route53Provider.go

[mathieuherbert]

Hi there,

I propose this PR to fix #82.
if KeyId and SecretKey are set, go sdk will use it otherwise it uses environment variable or IAM profile in an AWS Instance (default behavior of go sdk).

When go sdk performs a request to AWS it throw an error if credentials are not good.

It's my first PR here, I can improve it if you have any comment :)
I think I will propose the same in a next PR fo region when I have time.

[mathieuherbert]

I see last comments, I can add later the check on Route53 domain list.

[danielkza]

It probably is a good idea to remove the region hardcoding as well.

I see last comments, I can add later the check on Route53 domain list.

You can make the call with DryRun enabled, and it will just check if the provided credentials allow sufficient access.

[captncraig]

I have been a bit fuzzy on what the region means for route 53. Is it just the api urls you talk to? Would changing it allow you to talk to a closer api server, or is there more to it? Are zones tied to particular regions only, or will any region do? We hard coded it because it worked at the time. Totally open to better options. It could be specified with the credentials, or as provider-level metadata if it would even make sense to use different regions for different domains. Any help there is much appreciated.

[captncraig]

Yeah, my recommendation for using it would be to simply call getZones here from the initializer. Ideally detect an auth failure and print some useful message.

That would also have the advantage of having all the zones pre-fetched if a provider exists, and we can get rif of any other calls to getZones and checks that the zone list is populated.

[danielkza]

@captncraig

I have been a bit fuzzy on what the region means for route 53. Is it just the api urls you talk to? Would changing it allow you to talk to a closer api server, or is there more to it?

That's a good question, I'm not sure if it the API region really matters. But it would, of course, be better if we could follow usual SDK configuration if possible.

[mathieuherbert]

Hi,
I fetch credentials in getZones, fetch zones in the init method.
Also I add a check on DelegationSet if nil or not : I had a Hosted Zone Route53 without Delegation Set, it resulted to a segmentation fault.

[mathieuherbert]

For the region, Route53 is indeed a global service so it is not mandatory to specify another region that us-west-2. But often, when you set your AWS credentials in environment variables or aws credential file, you set also the region.

[mathieuherbert]

Up on this PR :)

[captncraig]

Looks pretty nice. Thank you!

[captncraig]

Could you just quickly update the docs to reflect the various configuration strategies possible?