Nameserver overhaul

[captncraig]

No description provided.

[tlimoncelli]

I'm not sure I understand this comment. 1 and 2 can't be true or false the way they are stated. Is 3 done if there are no NAMESERVER() or NAMESERVER_FROM() directives? Is there a way to disable DNS lookups? What if we just want the NS records untouched? How does the code work if the DNS servers are unreachable? can dnscontrol be used if DNS is down?

[captncraig]

Correct. 3 is only done if there are no NAMESERVER or NAMESERVER_FROM present.

No there isn't really a way to disable lookups from the dsps, short of defining nameserver records yourself. Good points though. Lets consider this:

D("so.com", REG_NAMECOM, R53, GCLOUD, NAMESERVERS_FROM(R53, GCLOUD))

If R53 is down, I see what you are saying. We would likely switch it to:

D("so.com", REG_NAMECOM, GCLOUD, NAMESERVERS_FROM(GCLOUD)) for the duration of the outage.

[captncraig]

And I believe that would only be neccessary if we need to change the records during the outage. If we are ok with them how they are, we wouldn't need to do anything.

It would likely be possible to add some kind of "Ignore Nameservers" mode, where we do not attempt to gather nameserver data, and also do not attempt any corrections on base-domain NS records. I'm not sure if the complexity is worth it though.

[tlimoncelli]

I missed the discussion about why we are doing DNS lookups. What problem are we trying to solve?

[captncraig]

We are not doing dns lookups. We are querying the providers (via GetNameservers method) to see what their "official" nameservers are for the domain.

[tlimoncelli]

Ah! It is an API call. Now I get it. I take back what I said.

Rather than query all the DSPs, why not be lazy and have (3) be "do no updates of the registered nameservers for this domain"? It is more predictable for the users and would have fewer surprises.

[captncraig]

Behaviour for 3 is partially for our own backward compatibility since that is what it does currently (sort of).

One issue I see is that dnscontrol is now trying to manage these NS records whenever possible. So any kind of ignore mode is "don't change nameservers and also ignore any/all corrections for the base NS records.

[captncraig]

Instead of DSPs defined by simple strings, now is DSP("name", count). If count is 0, no nameservers are used from that dsp. If not given, assume use all.

Collect nameservers from all dsps (by count) and register them. Make all NS records in all DSPs consistent with registered set. (to whatever degree possible).