Use circleci/python:3.6 image in CircleCI tests #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Is it possible to re-run a CircleCI test on a pull review using this code? |
|
Just Relaunched.
JP Bourget / @punkrokk
… On Sep 28, 2020, at 6:44 PM, tchiapuziowong ***@***.***> wrote:
Hello! Is it possible to re-run a CircleCI test on a pull review using this code?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Hello! My pull request #154 is failing due to CircleCI running in Python2.7 venv instead of Python3 - this commit should resolve that error correct? There's nothing to be done in the pack side? |
|
Hello! Is there any update to the status of this review? My pack seems to be dependent on this review in order to be merged. |
nmaludy
approved these changes
Oct 6, 2020
|
Hello - is there any update to this request? @blag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CircleCI tests for #154 failed because it relied on the Python 3-only package pyaoscx but the tests were running in a
circleci/python:2.7container.This PR updates the CI container to run in the most recent
circleci/python:3.6image, since all future packs should support Python 3. And frankly, at this point I think all new packs should only support Python 3, so I didn't even bother duplicating the workflow for Python 3.6, I just updated the existing workflow.