Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YAML lint checks #224

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Add YAML lint checks #224

merged 2 commits into from
Jan 11, 2019

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Jan 11, 2019 •
edited
Loading

YAML lint check is now recommended as Ansible Galaxy roles are scored based on set of automated verifications.

This should fix the StackStorm role rating at Ansible Galaxy.

armab added 2 commits January 11, 2019 22:22
Fix Yamllint validation errors
586890c
Add YAML lint check
f15674d 
Yaml lint check is recommended as Galaxy roles are scored based on set of automated verifications
@arm4b arm4b added this to the v1.0.0 milestone Jan 11, 2019
@arm4b arm4b added the RFR label Jan 11, 2019
LindsayHill
LindsayHill approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@LindsayHill LindsayHill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Pleasing to see that we didn't need many changes for this one, and were already mostly compliant

@arm4b arm4b merged commit b946bdb into master Jan 11, 2019
@arm4b arm4b deleted the fix/yamllint branch January 11, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LindsayHill LindsayHill LindsayHill approved these changes

Assignees
No one assigned
Labels
enhancement RFR
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arm4b @LindsayHill