Install latest rabbitmq on all OSes #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
amanda11
changed the title
|
Blocked until have GHA - see #297. As not happy to move until have the CI runs ran on all 3 OSes. |
amanda11
changed the title
arm4b
reviewed
Nov 12, 2021
| @@ -0,0 +1,59 @@ | |||
| --- | |||
|
|
|||
| - name: RabbitMQ on RHEL8 requires module(perl:5.26) | |||
There was a problem hiding this comment.
Considering we moved to official RabbitMQ insructions (https://www.rabbitmq.com/install-rpm.html#package-cloud), is this perl requirement still a thing?
I see it's from the previous Ansible role.
There was a problem hiding this comment.
@armab I took it out and install was fine, so no-longer required.
arm4b
approved these changes
Nov 23, 2021
| gpgcheck: no | ||
| enabled: yes | ||
| sslverify: yes | ||
| when: ansible_facts.os_family == 'RedHat' |
There was a problem hiding this comment.
Considering the file is named rabbitmq_redhat.yml which is included conditionally depending on OS,
I think this line could be removed.
Suggested change
| when: ansible_facts.os_family == 'RedHat' |
| gpgcheck: no | ||
| enabled: yes | ||
| sslverify: yes | ||
| when: ansible_facts.os_family == 'RedHat' |
There was a problem hiding this comment.
Suggested change
| when: ansible_facts.os_family == 'RedHat' |
There was a problem hiding this comment.
@armab Good spot - will remove!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the ansible installer to install latest rabbitmq from PackageCloud, rather than version bundled in OS.