Add --force-pip-flag, logging improvements #2
Conversation
to and use inside the created dh virtual environment. In addition to that, update create_virtualenv() step to print actual versions of the tools which are installed into virtualenv. This new --pip-binary flag should be used in combination with --virtualenv-extra-args="--no-pip" where we want to use a correct system version of pip is used instead of the one bundled with virtual environment. Also add --force-pip-version which allows us to install a specific version of pip inside venv.
|
NOTE: It appears build has been broken for a while and I don't plan to fix it at this point since it's not a blocker. |
|
I'd rather use upstream's |
|
PR: spotify#267 |
|
If we are doing backporting, we should just sync it with latest upstream and cherry pick the changes we need from our fork (iirc, it's only the shebang line). |
|
I got the shebang line fixes merged into upstream already: spotify#317 If we utilize the |
|
Great, that would be ideal :) Just need to make sure we update st2-packages Makefile to use this flag and st2packaging-dockerfiles once the fork is in sync. And of course verify it works (I added additional logging to st2-packages so we should be able to confirm pip versions everywhre by checking the log output of the build step). |
|
|
This pull request adds new
--force-pip-flagwith which we can force specific pip version to be used inside created virtualenv.In addition to that, it adds some logging improvements which will make easier to troubleshoot things and assert correct pip version is used.
This change is fully backward compatible if this flag is not used.