New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state change when workflow output fails rendering #102

Merged
merged 3 commits into from Nov 10, 2018

Conversation

Projects
None yet
3 participants
@m4dcoder
Copy link
Collaborator

m4dcoder commented Nov 9, 2018

If a workflow is already expired, abandoned, or canceled and there are errors rendering workflow output, keep the workflow state as is and don't change it to failed.

@m4dcoder m4dcoder requested a review from blag Nov 9, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 9, 2018

Codecov Report

Merging #102 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   94.23%   94.24%   +<.01%     
==========================================
  Files          38       38              
  Lines        2375     2379       +4     
  Branches      468      470       +2     
==========================================
+ Hits         2238     2242       +4     
  Misses         79       79              
  Partials       58       58
Impacted Files Coverage Δ
orquesta/conducting.py 91.94% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff06d7...7dcc711. Read the comment docs.

@blag

blag approved these changes Nov 9, 2018

m4dcoder added some commits Nov 9, 2018

Fix state change when workflow output fails rendering
If a workflow is already expired, abandoned, or canceled and there are errors rendering workflow output, keep the workflow state as is and don't change it to failed.
Ignore duplicate log entries
Before an entry is appended, match for duplicate and ignore if there is a match.

@m4dcoder m4dcoder force-pushed the fix-workflow-output-on-error branch from 97dfc79 to 7dcc711 Nov 10, 2018

@m4dcoder m4dcoder merged commit 475667b into master Nov 10, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@m4dcoder m4dcoder deleted the fix-workflow-output-on-error branch Nov 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment