Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PPA check else #691

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Fix PPA check else #691

merged 2 commits into from
Feb 23, 2021

Conversation

amanda11
Copy link
Contributor

When the insecure_ppa flag was set, it was skipping the install of deadsnakes ppa, due to incorrect else condition

@amanda11
Copy link
Contributor Author

Related to StackStorm/community#66

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Thanks for finding this!

@arm4b arm4b added the bug label Feb 23, 2021
@arm4b arm4b added this to the 3.5.0 milestone Feb 23, 2021
@blag blag merged commit e45e5d6 into master Feb 23, 2021
@blag blag deleted the fix_ppa_u16 branch February 23, 2021 23:06
@blag blag modified the milestones: 3.5.0, 3.4.0 Feb 23, 2021
@Kami
Copy link
Member

Kami commented Feb 24, 2021

We should hook up shell check or something like that to those scripts - I imagine shell check should be able to catch such error automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants