Skip to content

Commit

Permalink
Fix broken test which used an invalid mock object which wasn't an mon…
Browse files Browse the repository at this point in the history
…goengine

model.
  • Loading branch information
Kami committed Jul 13, 2016
1 parent d3c2db7 commit ac788ab
Showing 1 changed file with 10 additions and 12 deletions.
22 changes: 10 additions & 12 deletions st2reactor/tests/unit/test_sensor_wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,16 @@

import st2tests.config as tests_config
from st2tests.base import TESTS_CONFIG_PATH
from st2common.models.db.trigger import TriggerDB
from st2reactor.container.sensor_wrapper import SensorWrapper
from st2reactor.sensor.base import Sensor, PollingSensor

CURRENT_DIR = os.path.abspath(os.path.dirname(__file__))
RESOURCES_DIR = os.path.abspath(os.path.join(CURRENT_DIR, '../resources'))


class Trigger(object):
def __init__(self, id, type, data=None):
self.id = id
self.type = type
self.data = data or {}
self._data = data or {}
__all__ = [
'SensorWrapperTestCase'
]


class SensorWrapperTestCase(unittest2.TestCase):
Expand All @@ -39,6 +36,7 @@ def test_sensor_instance_has_sensor_service(self):
self.assertTrue(getattr(wrapper._sensor_instance, 'config', None) is not None)

def test_trigger_cud_event_handlers(self):
trigger_id = '57861fcb0640fd1524e577c0'
file_path = os.path.join(RESOURCES_DIR, 'test_sensor.py')
trigger_types = ['trigger1', 'trigger2']
parent_args = ['--config-file', TESTS_CONFIG_PATH]
Expand All @@ -57,23 +55,23 @@ def test_trigger_cud_event_handlers(self):
# Call create handler with a trigger which refers to this sensor
self.assertEqual(wrapper._sensor_instance.add_trigger.call_count, 0)

trigger = Trigger(id='2', type=trigger_types[0])
trigger = TriggerDB(id=trigger_id, name='test', pack='dummy', type=trigger_types[0])
wrapper._handle_create_trigger(trigger=trigger)
self.assertEqual(wrapper._trigger_names, {'2': trigger})
self.assertEqual(wrapper._trigger_names, {trigger_id: trigger})
self.assertEqual(wrapper._sensor_instance.add_trigger.call_count, 1)

# Validate that update handler updates the trigger_names
self.assertEqual(wrapper._sensor_instance.update_trigger.call_count, 0)

trigger = Trigger(id='2', type=trigger_types[0])
trigger = TriggerDB(id=trigger_id, name='test', pack='dummy', type=trigger_types[0])
wrapper._handle_update_trigger(trigger=trigger)
self.assertEqual(wrapper._trigger_names, {'2': trigger})
self.assertEqual(wrapper._trigger_names, {trigger_id: trigger})
self.assertEqual(wrapper._sensor_instance.update_trigger.call_count, 1)

# Validate that delete handler deletes the trigger from trigger_names
self.assertEqual(wrapper._sensor_instance.remove_trigger.call_count, 0)

trigger = Trigger(id='2', type=trigger_types[0])
trigger = TriggerDB(id=trigger_id, name='test', pack='dummy', type=trigger_types[0])
wrapper._handle_delete_trigger(trigger=trigger)
self.assertEqual(wrapper._trigger_names, {})
self.assertEqual(wrapper._sensor_instance.remove_trigger.call_count, 1)
Expand Down

0 comments on commit ac788ab

Please sign in to comment.