Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runners Version Incorrect #4210

Open
bigmstone opened this issue Jun 28, 2018 · 1 comment
Open

Runners Version Incorrect #4210

bigmstone opened this issue Jun 28, 2018 · 1 comment

Comments

@bigmstone
Copy link
Contributor

SUMMARY

Runners should have their version set automatically like the rest of ST2's components instead of hard coded (currently to 2.5.0)

ISSUE TYPE
  • Bug Report
@Kami Kami added this to the 2.9.0 milestone Jun 28, 2018
@Kami
Copy link
Member

Kami commented Jun 28, 2018

Yeah, we eventually need to move away from the way we currently install / use runners (mostly by manipulating PYTHONPATH when loading / instantiating a runner) to install them in the same way as any other Python dependency.

That means building wheels for those runner packages and then installing them into bundled st2 Python virtualenv during package build process.

All the runners are now Python packages so that should be possible. It will require some small amount of work in st2 (mostly removing loading code) and more work on the infra / building packages code.

I tagged it as 2.9.0 task since I would like to see that solved soon with the Orchestra issue we are having. Before orchestra it wasn't a priority, but now it is, so we can get rid of the hack / workaround in st2-packages post install script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants