Pass many 'register' components for 'packs.install', 'packs.load', 'st2ctl reload' #1619

[arm4b]

Problem

One of the problems described in #1619 is that packs.install reloads only actions by default, bringing problems (especially in ChatOps) when installed pack contains aliases or sensors:

st2 run packs.install packs=st2-google repo_url=jfryman/st2-google

Solution

This PR brings possibility to pass several register components.
If not provided register=actions,aliases,sensors is default value.

# before (1 component only):
st2 run packs.load register=actions

# now:
st2 run packs.install packs=hubot register=aliases,rules
st2 run packs.load register=rules,sensors

which would trigger reload with many arguments (only 1 was accepted before):

st2ctl reload --register-aliases --register-rules

[Kami]

Yeah, this is a lot better. Hated this monstrosity :P

[Kami]

I'm just slightly worried, since I don't remember if we have any end to end tests for st2ctl.

If we don't, now it would be a good time to add some to st2tests repo.

[arm4b]

st2tests looks like some kind of acceptance tests, pretty cool thing. I'll do it a bit later.

@Kami StackStorm/st2tests#16

[manasdk]

This works for me. We can sort out the array pieces laters.

The only drawback with string are the type is that actions, sensors, aliases is not the same as actions,sensors,aliases. You could write a trim filter for jinja if motivated to support both

[arm4b]

actions, sensors, aliases

Good point,
I've checked st2 run packs.install packs="hubot, ansible" is parsed well, so I would like to include trim logic here for consistency.

[arm4b]

@manasdk when you'll have time take a look at that #1231 (comment) if it's possible to do it in right way.

Splitting that string into array is absolutely dirty hackery. If possible, I would be happy to use an array there.

[arm4b]

@Kami if this PR looks ok for you, can you double-check and merge it?
Or should I include st2tests first?

[Kami]

Sorry for the delay. I will go ahead, test it and if everything looks OK, merge it.

Tests are not a blocker right now, but having them asap would be great :)

[Kami]

Merged into master - changes look and work fine.

Thanks.

[arm4b]

Thanks!