Integration Tests via Travis #1729
Conversation
launchdev.sh always exits with 1, because of `screen -ls`:
$ screen -ls; echo Exit Code: $?
There are screens on:
4333.st2-auth (07/17/2015 06:55:44 AM) (Detached)
4330.st2-notifier (07/17/2015 06:55:44 AM) (Detached)
4327.st2-resultstracker (07/17/2015 06:55:44 AM) (Detached)
4324.st2-rulesengine (07/17/2015 06:55:43 AM) (Detached)
4321.st2-sensorcontainer (07/17/2015 06:55:43 AM) (Detached)
4317.st2-actionrunner-1 (07/17/2015 06:55:43 AM) (Detached)
4314.st2-api (07/17/2015 06:55:43 AM) (Detached)
7 Sockets in /var/run/screen/S-vagrant.
Exit Code: 1
Don't forget to revert this commit after debugging and fixing
|
@manasdk @lakshmi-kannan @Kami this is where I'm in stuck and need your help/ideas:
I've included this PR in shared Except of this error, Integration tests in Travis should work OK (verified before in my forked branch). |
Travis runs under Ubuntu 12.04 LTS with outdated gpg. Strange compatibility issues are possible.
This reverts commit c45aa5f.
|
Hm, looking at the changes, we don't run "lint" task anymore? Or am I missing something and we run it as part of a separate job now? |
|
Ignore my last comment. I just now saw the "Remove code style checks from Travis (in favor of Scrutinizer)" line in the PR description. I'm personally not too big of a fan of that. I'd prefer to run everything on Travis CI. This way you only need to go to a single page to see the results. |
|
@Kami There are also some advantages behind that, see: #1724 And errored build looks pretty nice: Also in usual Travis build if something exited with error - further execution is stopped. See Scrutinizer ^^ log. All tasks are processed, which is especially good for different code style checks. |
Include entire st2 project in tests scope, remove limiting `--cover-package` argument when running tests. This fixes coverage, providing fair reports. Eg. now when running tests for example in `st2actions`, other st2 modules triggered in tests are included in coverage.
arm4b
force-pushed
the
travis-integration-tests
branch
from
ca1e1c7
to
1788262
Compare
|
Last commit provides more fair, aggregate coverage reports.
@Kami @lakshmi-kannan @manasdk this PR is ready for review now 👀 |
That's awesome. |
|
LGTM. |
|
LGTM. I'll merge. |
Integration Tests via Travis
test_encrypt_archive(),encrypt_archive()with gpg integration test issue