Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Python client library for st2. #1730

Closed
wants to merge 2 commits into from
Closed

Conversation

lakshmi-kannan
Copy link
Contributor

I am actually establishing overall how the new client library is going to look. I just started hacking things to satisfy my urge. Mostly not ready for review.

from st2pyclient.http_client.base import BaseClient


class AuthedClient(BaseClient):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to compose or even use a mixin for auth.

@Kami
Copy link
Member

Kami commented Jul 18, 2015

I would prefer to have two packages - st2client (Python client library) and st2cli (CLI which depends on the client library).

I assume you used st2pyclient name to avoid renaming and conflicts with the existing st2client package. I'm fine with doing that right, but before any code starts depending on it we should sort out the names.

@lakshmi-kannan
Copy link
Contributor Author

I would prefer to have two packages - st2client (Python client library) and st2cli (CLI which depends on the client library).

Yes, that's the plan.

I assume you used st2pyclient name to avoid renaming and conflicts with the existing st2client package. I'm fine with doing that right, but before any code starts depending on it we should sort out the names.

Aye aye.

Development in my fork. Closing this PR. Will open a new PR in my fork.

@lakshmi-kannan lakshmi-kannan deleted the st2_py_client branch August 9, 2015 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants