[WIP] Upgrade pylint to 1.5.x #2249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dicts and lists. This way pylint detection can be smarter since it's also aware of the attribute type.
datetime.datetime objects look like.
| # Hack for attributes with multiple types (e.g. string, null) | ||
| property_type = property_type[0] | ||
|
|
||
| if property_type == 'object': |
There was a problem hiding this comment.
This is cool since pylint is now also aware of each API model attribute type.
It means we get improved static checking for API model members (e.g. if API model attribute type is defined as string and you want perform division on it, pylint will now throw since it knows the attribute type is string a not int / float).
|
I decided to wait with upgrade to pylint 1.5.0 since I found some more blocking regressions in pylint. I will cherry-pick other improvements in a new branch and get back to this branch once new version of pylint with fixes is released. |
Merged
Merged
|
Superseded by #2613. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrades pylint and astroid to latest version which include some checking related improvements.
In addition that, it includes some lint cleanup and related improvements.