Minor fixes to validation of runner parameter override #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type for the headers parameter in the http-request runner should be object. Override of the type attribute is not allowed for runner parameters.
Include the action reference (i.e. core.local) in the error message on action parameter validation. If not included and there are failures from multiple actions on register, it will be difficult to troubleshoot.
Refactor the logic for validating runner parameter overrides to a utility method.
m4dcoder
added a commit
that referenced
this pull request
Jan 8, 2016
Minor fixes to validation of runner parameter override
| raise InvalidActionParameterException( | ||
| 'The attribute "%s" for the runner parameter "%s" cannot' | ||
| 'be overridden.' % (attribute, name)) | ||
| validate_runner_parameter_attribute_override( |
There was a problem hiding this comment.
In the future please prefer to use keyword argument when calling functions.
While working on resolving merge conflicts in my PR, I believe I encounter a minor issue - function order is `runner_param_attr_value, action_param_attr_value), but the values here are passed to the function in the reverse order.
Luckily, in this case the order doesn't matter, because those values are only used in a simple != if condition, but it could matter in other scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.