New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include number of elapsed seconds for completed executions in "st2 execution get" CLI command output #2482
Conversation
…ompleted when using "st2 execution get" command.
Make sure we strip elapsed from the output since we can't consistently assert on the number of seconds elapsed.
… of seconds elapsed.
LIVEACTION_STATUS_CANCELING = 'canceling' | ||
LIVEACTION_STATUS_CANCELED = 'canceled' | ||
|
||
|
||
LIVEACTION_COMPLETED_STATES = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to copy this over since we still can't have st2client to depend on st2common.
Packages will make that easier though, we just need to make sure we also publish st2common to PyPi.
While working on this I believe a noticed a bug with live instances - we don't always set I will look into it. |
…on model when formatting child instances (tasks).
Ignore my last comment. It turns out it was a CLI bug which I have just fixed. |
👍 |
It's funny how the last screenshot shows 13s in one place and 14s in another place :P. |
Isn't that expected? 14s for the parent execution and 13s for the child. I assume rounding errors kicked in since nothing takes 0s to complete. Unsure if you point that out as a bug of just quirk of rounding errors? If so then I will welcome myself back to an hour ago when you posted. |
Yeah, I was referring to rounding errors. |
Yep, it's total execution vs child execution run time + rounding :P |
Conflicts: CHANGELOG.rst
…complete_actions Include number of elapsed seconds for completed executions in "st2 execution get" CLI command output
The title says it all.
This should make it easier to see, at a glance, how long it took for the execution to complete and potentially adjust the action timeouts accordingly.