Allow user to specify a blacklist of attributes which are masked in the log messages #3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakshmi-kannan
approved these changes
Apr 10, 2017
|
We might need this at a per action level. Base runner should expose this attribute. Can you file an issue for this so we can add the feature later? |
|
@lakshmi-kannan Yes, we use secret parameters for actions and API level secrets masking, but that's slightly different than log message secrets masking. It would simply be too expensive if we needed to do a DB query or similar for each log message call. Also, see related explanation in StackStorm/st2docs#459. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default we use a static blacklist of parameter names (password, token, etc.) which are masked in the log message
extraiflog.mask_secretsconfig option is set toTrue.This pull request allows administrator to define an additional custom list of attributes which are masked in the log messages.
Related PR StackStorm/st2docs#459.