Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max retry delay for retry policy from 5 to 120 seconds #3637

Merged
merged 6 commits into from
Feb 26, 2018

Conversation

Kami
Copy link
Member

@Kami Kami commented Aug 1, 2017

User reported this limitation in #3630.

Because of the way retries are currently implemented, long retries are not really recommended, but @lakshmi-kannan and I agreed it still makes sense to support longer retry delays / intervals as long as we document this limitation and suggest alternative (e.g. using an interval trigger instead of retry).

Part of #3630.

TODO

  • Documentation change

@lakshmi-kannan
Copy link
Contributor

I am +1 to merging this. @m4dcoder wdyt?

Copy link
Contributor

@m4dcoder m4dcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kami LGTM. I agree here that this is not restart safe. Please rebase and get CI pass again.

@Kami Kami added this to the 2.7.0 milestone Feb 26, 2018
@Kami Kami merged commit cd7cdbb into master Feb 26, 2018
@Kami Kami deleted the bump_max_retry_interval branch February 26, 2018 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants