Added capability to transform_array function to escape colons #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Mierdin
force-pushed
the
escape-colon-formatter
branch
from
0ae1dfc
to
2535967
Compare
|
Some internal feedback seemed to indicate that this approach wasn't ideal for some users. Should ponder the approach further - maybe instead of allowing escape, provide a CLI option to |
|
Good catch 👍 And yeah we have a lot of code which allows users to specify complex type in an "easier" manner, but in general that's quite hard and there are a lot of edge cases. Are we targeting this for v2.5.1? |
Kami
reviewed
Dec 11, 2017
| mockarg = mock.Mock() | ||
| mockarg.inherit_env = False | ||
| mockarg.parameters = [ | ||
| 'param_array=foo\:bar,foo2:bar2', |
There was a problem hiding this comment.
If we decide to go with this approach, some more test cases would be great (e.g. more than two items, etc.)
|
Closing in favor of #3909 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3670 introduced a cool new capability to split strings in an array parameter on a colon
:character in order to specify a dictionary more easily.However, this breaks use cases where the user wants to provide an array of strings that all contain
:and doesn't want them split. For instance, some network interfaces have a colon in their name and it shouldn't be split up.This PR builds on the work in #3670 and uses a negative lookbehind regular expression to ensure that the colon in question isn't preceded by a backslash:
\. So, the user can place this behind the colon, and this conversion will be skipped.