Throw a more user-friendly error on invalid file path when resolving path to a pack resource #4046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we auto-generate https://api.stackstorm.com/ somehow based on latest API definition? |
|
IIRC, we re-generate it on master build, but I could be wrong - @enykeev should know for sure. |
|
From S3, last update: Something to keep in mind, when pointing to https://api.stackstorm.com/ in #community. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For security reasons (to avoid directory traversal attacks, writing outside of the pack directory, etc.), we only allow users to write pack data files inside the pack directory.
The error we threw before was a bit ambiguous and not user-friendly so this PR fixes that.
Before:
After:
Related issue #4039.