Add missing scope, decrypt and encrypt args to the datastore related methods on SensorService #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_value and delete_value methods on the SensorWrapper class.
mxmader
approved these changes
Apr 3, 2018
with the correct arguments.
…atastore_args_to_sensor_service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds missing arguments (scope, decrypt, encrypt) to the datastore management related methods on the SensorService class.
It was still possible to utilize those arguments by directly accessing
datastoreservice on theSensorServiceclass, but that was more of a workaround.I assume this was simply and oversight and we didn't add those when adding scope and encryption stuff (@lakshmi-kannan would be good if you can confirm).
Resolves #3895 #4057