Fix virtualenv-osx #4283
Merged
Fix virtualenv-osx #4283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2018 14:11
Beforehand, it was throwing ``` # Setup PYTHONPATH in bash activate script... # Delete existing entries (if any) sed -i '/_OLD_PYTHONPATHp/d' virtualenv-osx/bin/activate sed: 1: "virtualenv-osx/bin/acti ...": invalid command code v make: *** [virtualenv] Error 1 ```
enykeev
force-pushed
the
fix/virtualenv-osx
branch
from
30280cf
to
7c42336
Compare
|
Travis is failing, can you please have a look. |
added 2 commits
November 26, 2018 10:56
* master: (787 commits) Add a comment and use a constant. Add sleep to mitigate race. Fix lint, update comment. Remove metrics instrumentation for _get_next_execution method. Add additional loggic which will allow us to cross reference and trace operations over multiple scheduler processes. Fix a race in the test. Update descriptions. Add some comments and missing explicit return None. Use smaller interval for tests to speed things up. Remove debug option. Update affected tests. Update config gen script, rengerate sample config. Remove unused config options. Remove now unused file and config options. Move new config options to the correct place. Fix a bug with metrics decorator - argument was getting injected when it shouldn't have. Use a better, more consitent and explicit naming. Use consistent and correct naming. All the DB models repsent an instance of a particular type so should use a singular name form. Use decorator to instrument with metrics and don't instrument "spawn" call since it makes no sense - spawn call is non blocking and should return immediately. Allow user to configure scheduler sleep and gc run interval in the config. Update more affected tests. ...
Kami
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.