Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Add Python3.7 to CI pipeline #4855

Closed
wants to merge 20 commits into from
Closed

Conversation

nzlosh
Copy link
Contributor

@nzlosh nzlosh commented Jan 29, 2020

Part of the proposal #4844 is to add Debian 10 Buster using Python 3.7

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Jan 29, 2020
@nzlosh
Copy link
Contributor Author

nzlosh commented Jan 30, 2020

@Kami Do you have any suggestions on where to start looking for the test failures for Python 3.7?

1) FAIL: test_worker_shutdown (tests.unit.test_worker.WorkerTestCase)
----------------------------------------------------------------------
   Traceback (most recent call last):
    st2actions/tests/unit/test_worker.py line 130 in test_worker_shutdown
      str(liveaction_db))
   AssertionError: 'failed' != 'abandoned'
   - failed
   + abandoned

@nzlosh
Copy link
Contributor Author

nzlosh commented Jan 30, 2020

It looks like the error may be related to this issue eventlet/eventlet#592

@arm4b arm4b requested a review from Kami January 30, 2020 13:09
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines. Requires some effort to review. and removed size/XS PR that changes 0-9 lines. Quick fix/merge. labels Jan 30, 2020
@nzlosh
Copy link
Contributor Author

nzlosh commented May 26, 2020

It looks like upstream has found a clean solution for support Python >=3.7
eventlet/eventlet#611

@nzlosh
Copy link
Contributor Author

nzlosh commented Jun 22, 2021

Closing this PR as abandoned.

@nzlosh nzlosh closed this Jun 22, 2021
@nzlosh nzlosh deleted the py37_support branch January 23, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature help wanted proposal python3 size/L PR that changes 100-499 lines. Requires some effort to review. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants