Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update various core and test dependencies to latest stable version #5215

Merged
merged 12 commits into from
Mar 31, 2021

Conversation

Kami
Copy link
Member

@Kami Kami commented Mar 30, 2021

This pull request includes some book keeping and upgrades various deps to latest stable versions.

Core dependencies:

Test dependencies:

  • astroid
  • zstandard
  • bandit
  • mock
  • nose-parallel
  • nose-timer
  • pylint
  • tox

There were some small backward incompatible changes in mongoengine which were caught by tests and fixed.

TODO

  • Changelog entry
  • Upgrade python-ldap dependency in another repo

@Kami Kami added this to the 3.5.0 milestone Mar 30, 2021
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines. Requires some effort to review. label Mar 30, 2021
@Kami
Copy link
Member Author

Kami commented Mar 31, 2021

To confirm there are no performance regressions (at least for the operations we have micro benchmarks for) in mongoengine / pymongo, I ran micro-benchmarks I added not too long ago and compared the results under different versions (0.18.0, 0.23.0).

Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just changelog missing.

@Kami Kami merged commit 469381e into master Mar 31, 2021
@Kami Kami deleted the deps_upgrades branch March 31, 2021 22:13
@Kami Kami mentioned this pull request Apr 22, 2021
4 tasks
cognifloyd added a commit to cognifloyd/stackstorm-vault that referenced this pull request May 29, 2021
For some reason the ssl module is hitting an infinite recursion error.
This might be CircleCI-specific, depending on the openssl lib they used
to compile python. The 3.7.0 version is supposed to be even more robust,
so it could also be something about v3.6.13. I have not reproduced the
error elsewhere, however.

The error began appearing after we updated requests from v2.23.0 to
v2.25.1 in StackStorm/st2#5215
In requests v2.24.0, it defaulted to using the python ssl module instead
of PyOpenSSL due to various SELinux issues. Before that it used
PyOpenSSL whenever it was installed. Since it worked with pyopenssl, we
just revert to using it for the tests in this repo.
See: psf/requests#5443
cognifloyd added a commit to cognifloyd/stackstorm-vault that referenced this pull request May 29, 2021
For some reason the ssl module is hitting an infinite recursion error.
This might be CircleCI-specific, depending on the openssl lib they used
to compile python. The 3.7.0 version is supposed to be even more robust,
so it could also be something about v3.6.13. I have not reproduced the
error elsewhere, however.

The error began appearing after we updated requests from v2.23.0 to
v2.25.1 in StackStorm/st2#5215
In requests v2.24.0, it defaulted to using the python ssl module instead
of PyOpenSSL due to various SELinux issues. Before that it used
PyOpenSSL whenever it was installed. Since it worked with pyopenssl, we
just revert to using it for the tests in this repo.
See: psf/requests#5443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependency size/L PR that changes 100-499 lines. Requires some effort to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants