-
-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change minimum garbage_collection TTL to 1 day from 7 #5287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding this setting and for the contribution @ericreeves ! 👍
We'll just need a CHANGELOG record for this and CLA signed based on Github bot message above.
Besides that, all good.
As for the current 3.5.0 we got code freeze already from the release team, the change will be included in the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that change seems reasonable to me 👍
A very simple change to modify the minimum TTL on the garbage collector, pulling it back to 1 day from 7.
It still seems quite reasonable to ensure the user doesn't specify "0".