Let's upgrade to node 6 #78
Conversation
|
Upgrading to node 6 will also pull the following:
first ideas, but could be also something else ¯_(ツ)_/¯ |
| @@ -14,6 +14,8 @@ TimeoutSec=60 | |||
| PrivateTmp=true | |||
| Restart=on-failure | |||
| RestartSec=5 | |||
| StandardOutput=syslog+console | |||
| StandardError=syslog+console | |||
There was a problem hiding this comment.
Does that fix hubot logging bug described here: StackStorm/st2-packages#300 ?
There was a problem hiding this comment.
It does not. This directive instructs journalctl to write to console which should get logged to /var/log according to docs but it doesn't. So sad.
There was a problem hiding this comment.
With this param, feels like the truth is out there.
Let's try this for st2chatops.service:
- ExecStart=/opt/stackstorm/chatops/bin/hubot $DAEMON_ARGS
+ ExecStart=exec bin/hubot $DAEMON_ARGS >> /var/log/st2/st2chatops.log 2>&1
package.json
Outdated
| @@ -19,9 +19,9 @@ | |||
| "hubot-xmpp" : "git+https://github.com/markstory/hubot-xmpp.git#94c3438e42778c53e38f6909939c514da50a0dca", | |||
| "hubot-hipchat" : "git+https://github.com/StackStorm/hubot-hipchat#sonnyp-patch", | |||
| "hubot-irc" : "git+https://github.com/nandub/hubot-irc#51d1f4b418fc039a456b7891c7f9bf836699cfdc", | |||
| "hubot-slack" : "^3.4.2" | |||
| "hubot-slack" : "^4.3.4" | |||
There was a problem hiding this comment.
From the reports in GitHub #56 (comment), StackStorm/st2docs#418 and community, this should also fix proxy support for Slack adapter 👍
cc @ytjohn
debian/control
Outdated
| @@ -11,7 +11,7 @@ Vcs-Browser: https://github.com/stackstorm/st2chatops | |||
| Package: st2chatops | |||
| Architecture: any | |||
| Pre-Depends: dpkg (>= 1.16.16) | |||
| Depends: nodejs (>= 4.0.0) | |||
| Depends: nodejs (>= 6.0.0) | |||
There was a problem hiding this comment.
Considering nodejs epopeya https://github.com/StackStorm/ops-infra/pull/206, please pin node versions to 6 for both deb/rpm.
So we won't install any node7 or node8 or whatever in future.
# Conflicts: # packagingenv/jessie/Dockerfile # packagingenv/wheezy/Dockerfile # testingenv/jessie/Dockerfile # testingenv/wheezy/Dockerfile
arm4b
force-pushed
the
issue_68/upgrade_to_node_6
branch
from
304bc66
to
2d09a69
Compare
Fixing the build optional dependency: ``` make[2]: Entering directory `/root/st2chatops/node_modules/node-icu-charset-detector/build' CXX(target) Release/obj.target/node-icu-charset-detector/node-icu-charset-detector.o ../node-icu-charset-detector.cpp:7:28: fatal error: unicode/ucsdet.h: No such file or directory #include <unicode/ucsdet.h> ```
This reverts commit a773fcb.
Fixes `iconv` vs node6 incompatibility, see: bnoordhuis/node-iconv#157
closes #68
fixes #56
This should be merged only when we are ready to release st2 2.4.0
hubot-stackstormversion to0.6