add pod graceful timeout override #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
arm4b
suggested changes
Sep 15, 2023
| @@ -1321,6 +1322,7 @@ spec: | |||
| {{- if and .Values.st2.packs.images (not .Values.st2.packs.volumes.enabled) }} | |||
| {{- include "stackstorm-ha.packs-initContainers" . | nindent 6 }} | |||
| {{- end }} | |||
| terminationGracePeriodSeconds: {{ .Values.st2actionrunner.terminationGracePeriodSeconds | default 300 }} | |||
There was a problem hiding this comment.
The 300 default looks pretty much hidden from the user's perspective.
add suggestion around terminationgraceperiodseconds Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>
|
@armab I added the requested changes. |
arm4b
reviewed
Oct 31, 2023
cognifloyd
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add graceful timeout option for pods.
this will allow a user to override it in values.yaml.
we need this to to along with the graceful timeout settings in st2actionrunner and st2workflowengine.