Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent init containers from persisting across helm upgrade #375

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

guzzijones
Copy link
Contributor

this pr prevents st2packs init containers from persisting across upgrades.
fixes #260

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Sep 7, 2023
arm4b
arm4b previously approved these changes Sep 15, 2023
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it to the https://github.com/StackStorm/stackstorm-k8s/blob/master/CHANGELOG.md?

Otherwise looks good.

templates/_helpers.tpl Outdated Show resolved Hide resolved
@arm4b arm4b dismissed their stale review September 15, 2023 14:54

potential bug

guzzijones and others added 2 commits September 25, 2023 22:52
Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>
add entry for pr
@guzzijones guzzijones merged commit 1156ae2 into StackStorm:master Oct 9, 2023
8 checks passed
@cognifloyd cognifloyd added bug Something isn't working Helm K8s labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Helm K8s size/XS PR that changes 0-9 lines. Quick fix/merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StackStorm-ha chart doesn't remove old initContainers for packs
4 participants