Update dependencies & support scala 2.13 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cchantep
commented
Mar 10, 2021
cchantep
commented
- Update dependencies and Scala version (support 2.13)
- Fix warnings/code smells
- Update CI
cchantep
commented
Mar 10, 2021
| @@ -1,25 +1,88 @@ | |||
| import Dependencies._ | |||
|
|
|||
| inThisBuild(List( | |||
There was a problem hiding this comment.
Update build to support Scala 2.13 and with property compilation options
| @@ -1,17 +1,17 @@ | |||
| import sbt._ | |||
|
|
|||
| object Dependencies { | |||
| val scalacheckVersion = "1.14.3" | |||
There was a problem hiding this comment.
Updated dependencies
| @@ -0,0 +1,54 @@ | |||
| import sbt.Keys._ | |||
There was a problem hiding this comment.
Scapegoat configuration to check code smell at compilation
| @@ -171,7 +171,10 @@ case class AkkaHttpWebContext(request: HttpRequest, | |||
| addResponseCookie(cookie) | |||
| } | |||
|
|
|||
| def addResponseCsrfCookie(): Unit = CsrfCookieAuthorizer(this, Some(sessionStorage.sessionLifetime)) | |||
| def addResponseCsrfCookie(): Unit = { | |||
| CsrfCookieAuthorizer(this, Some(sessionStorage.sessionLifetime)) | |||
There was a problem hiding this comment.
Discarded unit-value
hierynomus
requested changes
Mar 17, 2021
| @@ -150,7 +156,7 @@ class AkkaHttpSecurityTest extends WordSpecLike with Matchers with ScalatestRout | |||
| } ~> check { | |||
| status shouldEqual StatusCodes.OK | |||
| responseAs[String] shouldBe "called!" | |||
| headers.size shouldBe 1 | |||
| headers.size shouldBe 2 | |||
There was a problem hiding this comment.
Akka-HTTP no longer prevent duplicate from what I see
Closed
cchantep
force-pushed
the
task/update
branch
2 times, most recently
from
6614a0d
to
b70b796
Compare
hierynomus
approved these changes
Mar 18, 2021
|
Just noticed one more thing, we're using GH Actions nowadays, not the Travis build anymore. Can you update the flow to do the crosscompile and scapegoat also? Thanks! |
|
Scapegoat doesn't support 2.13 |
- Fix warnings/code smells - Update CI
|
done |
|
Up |
|
up |
|
Up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.