STAC-17136. Fix problem with sessionId #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the store. Swap the order of when the CSRF cookie was added in login callback to gurantee a valid sessionId is returned during login process.
hierynomus
approved these changes
Aug 3, 2022
|
Approved (from my holiday ;)) |
rb3ckers
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STAC-17136
Change description
Fix problem sessionId was not always validated if it was in the store. Swap the order of when the CSRF cookie was added in login callback to guarantee a valid sessionId is returned during login process.
Type of change
Related issues
Checklists
Development
Security
Code review