Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: IndexTrackingViewModel #973

Merged
merged 7 commits into from
Jun 21, 2023
Merged

refactor: IndexTrackingViewModel #973

merged 7 commits into from
Jun 21, 2023

Conversation

ferrarafer
Copy link
Contributor

No description provided.

@github-actions
Copy link

LCOV of commit d294b9e during Test Package #57

Summary coverage rate:
  lines......: 7.6% (282 of 3714 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                             |Lines       |Functions  |Branches    
  Filename                                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================================
  lib/src/view_models/base_view_models.dart                                  |48.2%     56|    -     0|    -      0
  lib/src/view_models/helpers/index_tracking_state_helper.dart               | 100%     24|    -     0|    -      0
  lib/src/view_models/index_tracking_viewmodel.dart                          | 0.0%      2|    -     0|    -      0

@ferrarafer ferrarafer marked this pull request as ready for review June 13, 2023 15:17
FilledStacks
FilledStacks approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@FilledStacks FilledStacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner

@FilledStacks FilledStacks merged commit 11db919 into pre-release Jun 21, 2023
@FilledStacks FilledStacks deleted the refactor/index-tracking-view-model branch June 21, 2023 12:04
ferrarafer added a commit that referenced this pull request Jun 22, 2023
@ferrarafer
fix: expose setCurrentWebPageIndex on IndexTrackingStateHelper (#976)
2057589 
refactor: IndexTrackingViewModel (#973)

* Add RouterServiceInterface to Stacked package
* Add setCurrentWebPageIndex method to IndexTrackingViewModel
* Update cupertino_icons on example apps
* Sort routes to match BottomNavigation items order
* Call setCurrentWebPageIndex on Class Constructor

Allows to set the index of the Bottom Navigation Bar using the current
route at Web Platform when app starts from scratch which means there is no state for the currentIndex property to track the selected button.

chore: Update router example (#967)

* Update router_example to test InitializableSingleton
FilledStacks pushed a commit that referenced this pull request Jun 22, 2023
@semantic-release-bot
chore(release): 3.4.1 [skip ci]
be50299 
## [3.4.1](v3.4.0...v3.4.1) (2023-06-22)

### Bug Fixes

* expose setCurrentWebPageIndex on IndexTrackingStateHelper ([#976](#976)) ([2057589](2057589)), closes [#973](#973) [#967](#967)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilledStacks FilledStacks FilledStacks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferrarafer @FilledStacks