Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Secret Name to point to Artifactory as a new default #92

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Change Secret Name to point to Artifactory as a new default #92

merged 2 commits into from
Jan 26, 2023

Conversation

kaitimmer
Copy link
Contributor

Type of Change

Changed the default settings for secret names to match our new internal default

  • Bugfix
  • Enhancement / new feature
  • [] Refactoring
  • Documentation

Checklist

  • Add relevant labels (for example type of change or patch/minor/major)
  • Make sure not to introduce some mistakes
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@kaitimmer kaitimmer requested a review from a team as a code owner January 25, 2023 12:28
flaxel
flaxel requested changes Jan 25, 2023
View reviewed changes
.github/workflows/template_gitops.yml Outdated Show resolved Hide resolved
@kaitimmer kaitimmer requested a review from flaxel January 26, 2023 10:39
flaxel
flaxel approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@flaxel flaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice. 🎉

@kaitimmer kaitimmer merged commit 06f8716 into main Jan 26, 2023
@kaitimmer kaitimmer deleted the set_artifactory_as_defalt branch January 26, 2023 10:54
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flaxel flaxel flaxel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaitimmer @flaxel