Merge pull request #115 from Staffbase/update_to_node_fetch_3

remove node-fetch library, node has an own fetch implementation since node 18
Staffbase · Mar 4, 2024 · a1510e8 · a1510e8
2 parents 2303e5d + d1e4bd7
commit a1510e8
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 32 deletions.
diff --git a/__tests__/jira.test.js b/__tests__/jira.test.js
@@ -1,5 +1,6 @@
 const Jira = require('../jira')
 
+// if you want to run the test locally, add an existing JIRA token and email to the new JIRA call
 xtest('foo', async () => {
   const jira = new Jira({ token: '***' })
 

diff --git a/arn.js b/arn.js
@@ -1,5 +1,3 @@
-const fetch = require('node-fetch');
-
 class Arn {
   constructor ({ webhookUrl }) {
     this.webhookUrl = webhookUrl || '';

diff --git a/dist/index.js b/dist/index.js
diff --git a/jira.js b/jira.js
@@ -1,5 +1,3 @@
-const fetch = require('node-fetch');
-
 class Jira {
   constructor ({ baseUrl, token, email }) {
     this.baseUrl = baseUrl || 'https://mitarbeiterapp.atlassian.net';

diff --git a/package.json b/package.json
@@ -14,8 +14,7 @@
   "author": "",
   "license": "ISC",
   "dependencies": {
-    "@actions/core": "^1.10.1",
-    "node-fetch": "^2.6.7"
+    "@actions/core": "^1.10.1"
   },
   "devDependencies": {
     "@atlassian-partner-engineering/eslint-config": "^5.1.0",

diff --git a/yarn.lock b/yarn.lock
@@ -4372,13 +4372,6 @@ nock@^13.2.9:
     json-stringify-safe "^5.0.1"
     propagate "^2.0.0"
 
-node-fetch@^2.6.7:
-  version "2.6.7"
-  resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.7.tgz#24de9fba827e3b4ae44dc8b20256a379160052ad"
-  integrity sha512-ZjMPFEfVx5j+y2yF35Kzx5sF7kDzxuDj6ziH4FFbOp87zKDZNx8yExJIb05OGF4Nlt9IHFIMBkRl41VdvcNdbQ==
-  dependencies:
-    whatwg-url "^5.0.0"
-
 node-int64@^0.4.0:
   version "0.4.0"
   resolved "https://registry.yarnpkg.com/node-int64/-/node-int64-0.4.0.tgz#87a9065cdb355d3182d8f94ce11188b825c68a3b"
@@ -5182,11 +5175,6 @@ to-regex-range@^5.0.1:
   dependencies:
     is-number "^7.0.0"
 
-tr46@~0.0.3:
-  version "0.0.3"
-  resolved "https://registry.yarnpkg.com/tr46/-/tr46-0.0.3.tgz#8184fd347dac9cdc185992f3a6622e14b9d9ab6a"
-  integrity sha512-N3WMsuqV66lT30CrXNbEjx4GEwlow3v6rr4mCcv6prnfwhS01rkgyFdjPNBYd9br7LpXV1+Emh01fHnq2Gdgrw==
-
 tsconfig-paths@^3.14.1:
   version "3.14.1"
   resolved "https://registry.yarnpkg.com/tsconfig-paths/-/tsconfig-paths-3.14.1.tgz#ba0734599e8ea36c862798e920bcf163277b137a"
@@ -5337,19 +5325,6 @@ walker@^1.0.8:
   dependencies:
     makeerror "1.0.12"
 
-webidl-conversions@^3.0.0:
-  version "3.0.1"
-  resolved "https://registry.yarnpkg.com/webidl-conversions/-/webidl-conversions-3.0.1.tgz#24534275e2a7bc6be7bc86611cc16ae0a5654871"
-  integrity sha512-2JAn3z8AR6rjK8Sm8orRC0h/bcl/DqL7tRPdGZ4I1CjdF+EaMLmYxBHyXuKL849eucPFhvBoxMsflfOb8kxaeQ==
-
-whatwg-url@^5.0.0:
-  version "5.0.0"
-  resolved "https://registry.yarnpkg.com/whatwg-url/-/whatwg-url-5.0.0.tgz#966454e8765462e37644d3626f6742ce8b70965d"
-  integrity sha512-saE57nupxk6v3HY35+jzBwYa0rKSy0XR8JSxZPwgLr7ys0IBzhGviA1/TUGJLmSVqs8pb9AnvICXEuOHLprYTw==
-  dependencies:
-    tr46 "~0.0.3"
-    webidl-conversions "^3.0.0"
-
 which-boxed-primitive@^1.0.2:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/which-boxed-primitive/-/which-boxed-primitive-1.0.2.tgz#13757bc89b209b049fe5d86430e21cf40a89a8e6"