Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some citations don't have links #41

Open
tayler6000 opened this issue Jul 2, 2023 · 6 comments
Open

Some citations don't have links #41

tayler6000 opened this issue Jul 2, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@tayler6000
Copy link
Contributor

Sometimes, Stampy will cite something but the link doesn't work. Asking Stampy Who is Robert Miles produces two citations that do not have links consistently. I've tried restarting the service and cache but this seems to always be the case. Your results may vary.

image

@tayler6000 tayler6000 added the bug Something isn't working label Jul 2, 2023
@FraserLee
Copy link
Collaborator

This isn't a bug, but an issue with the dataset. Some data (notably all the books) don't have anything we could link to. Usually in these cases googling the citation yields the source.

I agree that the current solution of linking to nothing feels a bit rough. The two real solutions I could envision would be:

  1. Just link to a DuckDuckGo search for the exact citation in these cases, hope that will bring it up
  2. Start an effort on the dataset to add links to all sources, like to corresponding publisher or author webpages for books

@FraserLee FraserLee added alignment-research-dataset and removed bug Something isn't working labels Jul 5, 2023
@ccstan99
Copy link
Collaborator

ccstan99 commented Jul 5, 2023

All the entries in the updated dataset should be valid urls, including books which will link to goodreads. We can mark as wontfix for now and double check again after the re-embedding the new ARD.

@FraserLee
Copy link
Collaborator

FraserLee commented Jul 5, 2023

sgtm 👍

@ccstan99 ccstan99 added the wontfix This will not be worked on label Jul 5, 2023
@tayler6000 tayler6000 added bug Something isn't working and removed wontfix This will not be worked on labels Jul 9, 2023
@tayler6000 tayler6000 assigned ccstan99 and mruwnik and unassigned ccstan99 Jul 9, 2023
@tayler6000
Copy link
Contributor Author

Related to StampyAI/alignment-research-dataset#2

@FraserLee
Copy link
Collaborator

if we should keep this open, lmk

@ccstan99
Copy link
Collaborator

I'd like to keep this open for now, as a placeholder, to avoid people creating new issues with essentially the same idea until we've fully resolved it.

DuckDuckGo is a good stop gap. It would be nice to also do that not only for empty urls but invalid urls, like private or removed pages. Hopefully, this'll be needed less and less but it's nice to have as a backup.

@FraserLee FraserLee reopened this Jul 13, 2023
@mruwnik mruwnik removed their assignment Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

4 participants