Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor float convert code to share multiply #132

Merged
merged 4 commits into from
Jun 14, 2019
Merged

Refactor float convert code to share multiply #132

merged 4 commits into from
Jun 14, 2019

Conversation

leonardt
Copy link
Contributor

No description provided.

@leonardt leonardt requested a review from rdaly525 June 14, 2019 00:22
@rdaly525 rdaly525 requested a review from cdonovick June 14, 2019 00:31
@rdaly525
Copy link
Contributor

@cdonovick, you should review this as well

rdaly525
rdaly525 approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@rdaly525 rdaly525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code refactors out the common 16 bit multiply for the two ops.

@rdaly525 rdaly525 merged commit f7cbf65 into master Jun 14, 2019
@rdaly525 rdaly525 mentioned this pull request Jun 14, 2019
Closed
44 tasks
@Kuree Kuree deleted the share-multiplies2 branch June 17, 2019 22:20
@phanrahan phanrahan mentioned this pull request Jul 10, 2019
Open
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdaly525 rdaly525 rdaly525 approved these changes

@cdonovick cdonovick Awaiting requested review from cdonovick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leonardt @rdaly525