-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Physical Effort Metric #40
Support for Physical Effort Metric #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the additions to HealthKitOnFHIR!
I had one comment in the PR.
It would be great if you can also adjust the documentation at https://github.com/StanfordBDHG/HealthKitOnFHIR/blob/main/Sources/HealthKitOnFHIR/HealthKitOnFHIR.docc/SupportedHKQuantityTypes.md to include the new type and mapping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvements and clarifications; this looks great to me!
Awesome! Thanks for the feedback. A few remaining details: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage 92.86% 92.86%
=======================================
Files 23 23
Lines 1092 1092
=======================================
Hits 1014 1014
Misses 78 78 Continue to review full report in Codecov by Sentry.
|
@MatthewTurk247 The deprivation warnings did not affect the unit test; it was an issue that the simulator was not starting properly. I have also fixed some flakey behavior in the UI tests. |
Support for Physical Effort Metric
♻️ Current situation & Problem
Currently, HealthKitOnFHIR does not support the
HKQuantityTypeIdentifierPhysicalEffort
type, a recent addition to HealthKit. Now we are adding the ability to encode a FHIR resource related to this physical effort metric, measured in metabolic equivalents (calories per hour per kilogram).⚙️ Release Notes
HKQuantityTypeIdentifierPhysicalEffort
in HealthKit extension to enable tracking of physical effort in kcal/hr/kg.📚 Documentation
This feature is implemented with an emphasis on maintaining consistency with existing types and ensuring that the new data can be seamlessly integrated with our tools and UI.
✅ Testing
See
HKQuantitySampleTests.swift
.Code of Conduct & Contributing Guidelines
By submitting creating this pull request, I agree to follow the Code of Conduct and Contributing Guidelines: