Improve ContactList layout and improve subtitle line breaking #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 80.07% 81.23% +1.17%
==========================================
Files 5 4 -1
Lines 311 309 -2
==========================================
+ Hits 249 251 +2
+ Misses 62 58 -4
Continue to review full report in Codecov by Sentry.
|
PSchmiedmayer
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Thank you for the great improvements; this looks great @Supereg! 🚀
|
Will tag the new SpeziViews later on and still include it in this PR. |
|
This looks much better! Thank you @Supereg! |
Supereg
added a commit
that referenced
this pull request
Nov 17, 2023
# Fix dark mode appearance ## ♻️ Current situation & Problem This PR fixes appearance in dark mode. Due to refactorings to lists in #18, we know have to adapt to different backgrounds (e.g., placed directly into a view, placed into a grouped background view, like a List cell). This was primarily an issue as we used a background color instead of a fill color (see [tertiarySystemFill](https://developer.apple.com/documentation/uikit/uicolor/3255076-tertiarysystemfill) being recommended for buttons and compare to [secondarySystemBackground](https://developer.apple.com/documentation/uikit/uicolor/3173137-secondarysystembackground) which we previously used). ## ⚙️ Release Notes * Fixes appearance in light background when appearing in Lists. ## 📚 Documentation -- ## ✅ Testing -- ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve ContactList layout and improve subtitle line breaking
♻️ Current situation & Problem
Currently, the
ContactsListview is built using a custom ScrollView implementation and drawing custom backgrounds with shades around theContactViews. This doesn't really feel native on iOS. Instead, this PR rethinks the implementation by rebuilding theContactsListview using SwiftUI standard components likeList. This makes theContactsListnow feel right at home.Further, previously the subtitle, consisting of the Person's title and organization, was built using multiple distinct
Textinstances. This caused problems when the text was longer than the view was capable of displaying. This PR ensures that a persons title and organization are combined into a singleTextview and allows to to wrap into a second line.Lastly, this PR migrates the PR to use String catalogs, optimizes key naming and bumps the target to iOS 17.
Below are two screenshots comparing the previous implementation to the updated one.
⚙️ Release Notes
ContactsViewthat feel way more native to iOS📚 Documentation
--
✅ Testing
Tests were slightly adjusted, due to issues with line breaks in the labels.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: