Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark mode appearance #19

Merged
merged 1 commit into from Nov 17, 2023
Merged

Fix dark mode appearance #19

merged 1 commit into from Nov 17, 2023

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Nov 17, 2023

Fix dark mode appearance

♻️ Current situation & Problem

This PR fixes appearance in dark mode. Due to refactorings to lists in #18, we know have to adapt to different backgrounds (e.g., placed directly into a view, placed into a grouped background view, like a List cell).
This was primarily an issue as we used a background color instead of a fill color (see tertiarySystemFill being recommended for buttons and compare to secondarySystemBackground which we previously used).

⚙️ Release Notes

  • Fixes appearance in light background when appearing in Lists.

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #19 (079d91e) into main (bd38bd7) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   81.23%   81.23%           
=======================================
  Files           4        4           
  Lines         309      309           
=======================================
  Hits          251      251           
  Misses         58       58           
Files Coverage Δ
...urces/SpeziContact/Contact Views/ContactView.swift 82.36% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd38bd7...079d91e. Read the comment docs.

@Supereg Supereg merged commit 0751541 into main Nov 17, 2023
7 checks passed
@Supereg Supereg deleted the fix/dark-mode-apperance branch November 17, 2023 22:37
@PSchmiedmayer
Copy link
Member

Nice, thank you for the fix @Supereg and thanks for taking over the review @philippzagar 🚀

@Supereg Supereg mentioned this pull request Jan 7, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants